Skip to content

Update Rails, Ruby, and add ruby debug gem #516

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 14 commits into from
Mar 1, 2023

Conversation

ahangarha
Copy link
Contributor

@ahangarha ahangarha commented Jan 17, 2023

In this PR:

  • Updated Rails to version 7+
  • Fixed builder missing template error
  • Added debug gem

Possible todos:


This change is Reviewable

@ahangarha ahangarha force-pushed the 515-update-rails-7-ruby-31-and-add-ruby-debug-gem branch from e5de01c to 3c7ceb1 Compare January 17, 2023 14:03
@ahangarha ahangarha requested a review from justin808 January 18, 2023 15:33
@ahangarha ahangarha force-pushed the 515-update-rails-7-ruby-31-and-add-ruby-debug-gem branch 2 times, most recently from a5a89ac to 1f8eef4 Compare January 18, 2023 16:27
@ahangarha ahangarha changed the title WIP - Update Rails, Ruby, and add ruby debug gem Update Rails, Ruby, and add ruby debug gem Jan 18, 2023
@ahangarha ahangarha force-pushed the 515-update-rails-7-ruby-31-and-add-ruby-debug-gem branch from fd981c1 to 1f8eef4 Compare January 18, 2023 17:14
@justin808
Copy link
Member

Did you follow the steps at https://guides.rubyonrails.org/upgrading_ruby_on_rails.html#upgrading-from-rails-6-1-to-rails-7-0?

@ahangarha ahangarha force-pushed the 515-update-rails-7-ruby-31-and-add-ruby-debug-gem branch 2 times, most recently from 71a75c6 to 9d646c5 Compare January 19, 2023 18:48
@ahangarha
Copy link
Contributor Author

ahangarha commented Jan 19, 2023

@justin808
I followed the mentioned upgrade guideline. Just there are two concerns:

  • Updating cache serialization format doesn't work. I couldn't make the test pass for this change so I omitted this change.
  • There is a new change in test environment config file related to eager loading. Since I was not sure about the right value, I kept the old value to work and added the new code as a comment.
  • I noticed an inconsistency in our CI tests. The same changes could sometimes pass and sometimes fail. Namely, the commit d825126 here (which passes the CI) failed twice at first. I removed the commit and made it again and it failed. I reran the CI and it passed. I am not sure what causes this issue but as per the log, it could be related to rspec-rails version.

Let me know if I should update changelog. As I see, it is not updated for a very long time.

@ahangarha
Copy link
Contributor Author

Few more concerns:

  • Our Jbuilder doc file needs to be updated. I edited the to be the same way used in pages_controller. I added a new react component in erb one of our views but it didn't work. (though I generated the correct data but the component failed in getting rendered on the page. This needs further investigation.
  • What to do with Travis config? It is very outdated and I think we can remove it.
  • It seems we don't use Codeship anymore. If so, let's remove the badge on README file and also its outdated documentation.
  • It seems our Gemnasium badge is broken.

@justin808 justin808 merged commit ad90eba into master Mar 1, 2023
@justin808 justin808 deleted the 515-update-rails-7-ruby-31-and-add-ruby-debug-gem branch March 1, 2023 21:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update Rails 7, Ruby 3.1, and add ruby-debug gem
2 participants